Heartbeat: implement in both live-reload servers (#6927)

remix-run · Jul 21, 2023 · 316ef06 · 316ef06
1 parent 3851934
commit 316ef06
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/remix-dev/devServer/liveReload.ts b/packages/remix-dev/devServer/liveReload.ts
@@ -76,7 +76,7 @@ export async function liveReload(config: RemixConfig) {
     }
   );
 
-  const heartbeat = setInterval(broadcast, 60000, { type: "PING" });
+  let heartbeat = setInterval(broadcast, 60000, { type: "PING" });
 
   exitHook(() => clean(config));
   return async () => {

diff --git a/packages/remix-dev/devServer_unstable/socket.ts b/packages/remix-dev/devServer_unstable/socket.ts
@@ -37,5 +37,12 @@ export let serve = (server: HTTPServer) => {
     broadcast({ type: "HMR", assetsManifest, updates });
   };
 
-  return { log, reload, hmr, close: wss.close };
+  let heartbeat = setInterval(broadcast, 60000, { type: "PING" });
+
+  let close = () => {
+    clearInterval(heartbeat);
+    return wss.close();
+  };
+
+  return { log, reload, hmr, close };
 };