Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP route modules for defineRoute #11761

Closed
wants to merge 4 commits into from
Closed

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jul 1, 2024

No description provided.

Copy link

changeset-bot bot commented Jul 1, 2024

⚠️ No Changeset found

Latest commit: 3ab7d56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -42,6 +42,7 @@ import {
resolvePublicPath,
} from "../config";
import * as defineRoute from "./define-route";
import exp from "node:constants";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this got auto-imported accidentally, will remove

exports are only ever used on the server. Without this optimization we can't
tree-shake any unused custom exports because routes are entry points. */
const BUILD_CLIENT_ROUTE_QUERY_STRING = "?__remix-build-client-route";
const ROUTE_ENTRY_QUERY_STRING = "?__react-router-entry=1";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the query string can be prettier ala ?entry=true or something since it doesn't affect URLs, just route module imports

@pcattori
Copy link
Contributor Author

pcattori commented Jul 1, 2024

obsoleted by #11762

@pcattori pcattori closed this Jul 1, 2024
@pcattori pcattori deleted the pedro/route-entry-virtual-modules branch July 1, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant