Fix optional parameter matching #10917
Conversation
🦋 Changeset detectedLatest commit: cb83034 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @neemzy, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Related: #9862 |
|
yeah I think this is a dup of #10768. I'll try to look over them soon and see if we can get one of them merged. |
|
@brophdawg11 FWIW that other PR you mentioned #10768 looks much better than whatever I hastily hacked together, if you want to reduce noise feel free to close this one and I'll follow that one. |
|
ok thanks! |
If I understood correctly, optional parameter (e.g.
/foo/:bar?) support was initially dropped in v6 before being reintroduced. However, upon trying to migrate an app from v5 to v6, I realizedmatchPathreturnsnullwhen trying to match a path against a pattern containing optional parameters, even though it should match.This PR fixes this, but in a probably hazardous way. This allows me to keep working on said migration while, hopefully, I can discuss this problem with you (and eventually implement a better solution for it).
Thanks!