remix-run · mjackson · Jun 12, 2020 · Nov 4, 2019 · Nov 4, 2019 · Nov 5, 2019
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,3 @@
+/cjs
+/esm
+/umd
diff --git a/.eslintrc b/.eslintrc
@@ -0,0 +1,23 @@
+{
+  "parser": "babel-eslint",
+  "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module"
+  },
+  "plugins": ["import"],
+  "env": {
+    "node": true
+  },
+  "extends": ["eslint:recommended", "plugin:import/errors"],
+  "rules": {
+    "prefer-arrow-callback": "error",
+    "no-unused-vars": [
+      "warn",
+      {
+        "args": "after-used",
+        "ignoreRestSiblings": true,
+        "argsIgnorePattern": "event"
+      }
+    ]
+  }
+}
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,5 @@
-/node_modules/
 /esm/
+/fixtures/history.js
 /cjs/
+/node_modules/
 /umd/
-/local.log
diff --git a/.size-snapshot.json b/.size-snapshot.json
@@ -1,26 +1,26 @@
 {
   "esm/history.js": {
-    "bundled": 28076,
-    "minified": 12353,
-    "gzipped": 3575,
+    "bundled": 18963,
+    "minified": 7493,
+    "gzipped": 2040,
     "treeshaked": {
       "rollup": {
-        "code": 208,
-        "import_statements": 132
+        "code": 43,
+        "import_statements": 43
       },
       "webpack": {
-        "code": 1324
+        "code": 1027
       }
     }
   },
   "umd/history.js": {
-    "bundled": 33021,
-    "minified": 11943,
-    "gzipped": 3917
+    "bundled": 20613,
+    "minified": 6873,
+    "gzipped": 2192
   },
   "umd/history.min.js": {
-    "bundled": 30384,
-    "minified": 9993,
-    "gzipped": 3501
+    "bundled": 18495,
+    "minified": 5944,
+    "gzipped": 1893
   }
 }
diff --git a/.travis.yml b/.travis.yml
@@ -1,17 +1,17 @@
 language: node_js
 node_js: node
 cache: yarn
-env:
-- TEST_ENV=cjs BUILD_ENV=cjs
-- TEST_ENV=umd BUILD_ENV=umd
-- TEST_ENV=source
-before_script:
-- ([[ -z "$BUILD_ENV" ]] || yarn build)
-script:
-- yarn lint
-- yarn test
 jobs:
   include:
+  - stage: Test
+    env: TEST_ENV=cjs BUILD_ENV=cjs
+    before_script: yarn build
+    script: yarn test
+  - env: TEST_ENV=umd BUILD_ENV=umd
+    before_script: yarn build
+    script: yarn test
+  - env: TEST_ENV=source
+    script: yarn test
   - stage: Release
     if: tag =~ ^v[0-9]
     env: NPM_TAG=$([[ "$TRAVIS_TAG" == *-* ]] && echo "next" || echo "latest")

diff --git a/DOMUtils.js b/DOMUtils.js
diff --git a/ExecutionEnvironment.js b/ExecutionEnvironment.js
diff --git a/LocationUtils.js b/LocationUtils.js
diff --git a/PathUtils.js b/PathUtils.js
diff --git a/createBrowserHistory.js b/createBrowserHistory.js
diff --git a/createHashHistory.js b/createHashHistory.js
diff --git a/createMemoryHistory.js b/createMemoryHistory.js
diff --git a/createTransitionManager.js b/createTransitionManager.js
diff --git a/es/DOMUtils.js b/es/DOMUtils.js
diff --git a/es/ExecutionEnvironment.js b/es/ExecutionEnvironment.js
diff --git a/es/LocationUtils.js b/es/LocationUtils.js
diff --git a/es/PathUtils.js b/es/PathUtils.js
diff --git a/es/createBrowserHistory.js b/es/createBrowserHistory.js
diff --git a/es/createHashHistory.js b/es/createHashHistory.js
diff --git a/es/createMemoryHistory.js b/es/createMemoryHistory.js
diff --git a/es/createTransitionManager.js b/es/createTransitionManager.js
diff --git a/es/warnAboutDeprecatedESMImport.js b/es/warnAboutDeprecatedESMImport.js
diff --git a/fixtures/unload-history.html b/fixtures/unload-history.html
@@ -0,0 +1,89 @@
+<!DOCTYPE html>
+<html>
+  <body>
+    <h1>Controls</h1>
+
+    <p>
+      <label><input type="checkbox" id="blocker" /> block</label>
+    </p>
+    <p>
+      <span>back &amp; forward: </span><br />
+      <button onclick="goBack()">back</button>
+      <button onclick="goForward()">forward</button>
+    </p>
+    <p>
+      <span>pushState &amp; replaceState: </span><br />
+      <a href="/unload-history" onclick="return pushLink(this)">pushState(home)</a>
+      <a href="/unload-history-one" onclick="return pushLink(this)">pushState(one)</a>
+      <a href="/unload-history-two" onclick="return pushLink(this)">pushState(two)</a>
+      <a href="/unload-history-three" onclick="return replaceLink(this)">replaceState(three)</a>
+    </p>
+    <p>
+      <span>regular link: </span><br />
+      <a href="/unload-history">home</a>
+    </p>
+
+    <h1>Test Scenarios</h1>
+
+    <p>
+      <ul>
+        <li>Click block - Click back - You should be prompted to stay</li>
+        <li>Click block - Click home - You should be prompted to stay</li>
+        <li>Click block - Close the tab - You should be prompted to stay</li>
+        <li>Click pushState(one) - Click block - Click back - You should still be at /unload-history-one</li>
+        <li>Click pushState(one) - Click block - Click pushState(two) - You should still be at /unload-history-one</li>
+        <li>Click pushState(one) - Click pushState(two) - Click back - Click block - Click back - You should still be at /unload-history-one</li>
+        <li>Click pushState(one) - Click pushState(two) - Click back - Click block - Click forward - You should still be at /unload-history-one</li>
+        <li>Click pushState(one) - Click pushState(two) - Click replaceState(three) - Click block - Click back - You should still be at /unload-history-three</li>
+      </ul>
+    </p>
+
+    <script src="history.js"></script>
+    <script>
+      var h = History.createBrowserHistory();
+
+      // Blocker
+
+      var blocker = document.getElementById('blocker');
+      var unblock;
+
+      blocker.addEventListener('change', () => {
+        if (blocker.checked) {
+          unblock = h.block(tx => {
+            if (window.confirm(`Are you sure you want to go to ${tx.location.pathname}?`)) {
+              // Reset the blocker so the next transition is allowed.
+              blocker.checked = false;
+              unblock();
+              // Retry the transition.
+              h.retry(tx);
+            }
+          });
+        } else if (unblock) {
+          unblock();
+          unblock = undefined;
+        }
+      });
+
+      // Navigation
+
+      function pushLink(link) {
+        h.navigate(link.getAttribute('href'));
+        return false; // preventDefault
+      }
+
+      function replaceLink(link) {
+        h.navigate(link.getAttribute('href'), { replace: true });
+        return false; // preventDefault
+      }
+
+      function goBack() {
+        h.back();
+      }
+
+      function goForward() {
+        h.forward();
+      }
+    </script>
+  </body>
+</html>
+