Bundle esm and cjs and remove path imports #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same structure as in react-router ``` esm/ history.js cjs/ history.js history.min.js umd/ history.js history.min.js ``` As you can see the code of this library is almost fully treeshakable. 1kb in webpack is just a runtime. Rollup result is more clean and shows only one not treeshaked side effect.
|
/cc @mjackson |
|
@mjackson if you are not ready for major release yet I can try another optimisations. |
|
/cc @mjackson |
|
This looks great, thanks @TrySound. I'd also like to include stubs of all our files that used to be in the root of the build just for the sake of anyone who was using them. Then we can go ahead and ship this in the same version w/out a major version bump. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same structure as in react-router
As you can see the code of this library is almost fully treeshakable.
1kb in webpack is just a runtime. Rollup result is more clean and shows
only one not treeshaked side effect.