Few minor tweaks for your tool #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting fixes |
|
I plan to add a time lapse feature... I hope to find spare time to do it. |
remisalmon
reviewed
Dec 6, 2023
jdicke
reviewed
Feb 17, 2024
| # converting files | ||
| for gpx_file in gpx_files: | ||
| print('Converting {}'.format(os.path.basename(gpx_file))) | ||
| with open(gpx_file, encoding='utf-8') as file: |
There was a problem hiding this comment.
Consider adding try catch since this is file operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was willing to generate heat map from gpx tracks generated by Polar watch (not strava).
Those files are non formatted, everything on the same line. Thus I had to convert those files before processing them.
I also added recursive search in GPX directory (my tracks were sorted by year)
And least important, I had to change one minor thing about tuple for python 3.8 to be supported.
If you think those are of interest, feel free to pull them.