no-paragraph-content-indent: fix crash caused by empty alt

Closes GH-173. Closes GH-172.
remarkjs · Mar 9, 2018 · c23a5ec · c23a5ec
1 parent 0c028a3
commit c23a5ec
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/remark-lint-no-paragraph-content-indent/index.js b/packages/remark-lint-no-paragraph-content-indent/index.js
@@ -32,6 +32,8 @@
  *
  *   ![image reference][] text
  *
+ *   [![][text]][text]
+ *
  * @example {"name": "invalid.md", "label": "input"}
  *
  *   ·Alpha
@@ -56,6 +58,8 @@
  *
  *   ![ image reference][] text
  *
+ *   [![ ][text]][text]
+ *
  * @example {"name": "invalid.md", "label": "output"}
  *
  *   1:1: Expected no indentation in paragraph content
@@ -67,6 +71,7 @@
  *   17:5: Expected no indentation in paragraph content
  *   19:1: Expected no indentation in paragraph content
  *   21:1: Expected no indentation in paragraph content
+ *   23:2: Expected no indentation in paragraph content
  */
 
 'use strict';
@@ -104,7 +109,7 @@ function noParagraphContentIndent(tree, file) {
         return;
       }
 
-      if (first === true && ws(toString(node).charAt(0))) {
+      if (first && ws(toString(node).charAt(0))) {
         file.message(message, node.position.start);
       }
 
@@ -163,7 +168,7 @@ function head(node) {
 }
 
 function applicable(node) {
-  return 'value' in node || 'alt' in node;
+  return 'value' in node || node.alt;
 }
 
 function toString(node) {

diff --git a/packages/remark-lint-no-paragraph-content-indent/readme.md b/packages/remark-lint-no-paragraph-content-indent/readme.md
@@ -38,6 +38,8 @@ juliett.
 ![image]() text
 
 ![image reference][] text
+
+[![][text]][text]
 ```
 
 ###### Out
@@ -72,6 +74,8 @@ Bravo
 ![ image]() text
 
 ![ image reference][] text
+
+[![ ][text]][text]
 ```
 
 ###### Out
@@ -86,6 +90,7 @@ Bravo
 17:5: Expected no indentation in paragraph content
 19:1: Expected no indentation in paragraph content
 21:1: Expected no indentation in paragraph content
+23:2: Expected no indentation in paragraph content
 ```
 
 ## Install