Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output: Add fast shutdown, max session duration. Rename metric labels. #15

Merged
merged 1 commit into from
Sep 30, 2021
Merged

output: Add fast shutdown, max session duration. Rename metric labels. #15

merged 1 commit into from
Sep 30, 2021

Conversation

jiping-s
Copy link
Collaborator

@jiping-s jiping-s commented Sep 16, 2021 •
edited
Loading

Metrics:

  • configurable metric labels are renamed from "label"

Common output: (affecting Fluentd output mainly)

  • Allow session opening to be interrupted without waiting for timeout
  • Allow session to be interrupted while sending log batches without waiting for timeout
  • Add configurable max duration for sessions to help load balancing. When a session is closed due to max duration, it waits for ACK gracefully and there would be no delay before next session.

The changes made output even more complicated and this will be addressed in #17

Co-authored-by: Federico Leva federico.leva@relexsolutions.com
Co-authored-by: Johannes Staffans johannes.staffans@relexsolutions.com
Co-authored-by: Pedro Trigueros pedro.trigueros@relexsolutions.com

This was linked to issues Sep 16, 2021
all: Limit amounts of logs from the agent itself #5
Open
output: Add fast shutdown and make it optional if possible #3
Closed
@jiping-s jiping-s changed the title WIP: output: #3 fast shutdown and limit session duration WIP: output: fast shutdown and limit session duration Sep 16, 2021
@jiping-s jiping-s removed a link to an issue Sep 16, 2021
all: Limit amounts of logs from the agent itself #5
Open
@jiping-s jiping-s linked an issue Sep 16, 2021 that may be closed by this pull request
output: Limit max duration of outgoing connection to help load balancing #6
Closed
@jiping-s jiping-s force-pushed the workshop3 branch 2 times, most recently from 013f8b4 to 37915c5 Compare September 29, 2021 14:21
@jiping-s jiping-s changed the title WIP: output: fast shutdown and limit session duration output: Add fast shutdown, max session duration. Rename metric labels. Sep 29, 2021
jstaffans
jstaffans approved these changes Sep 29, 2021
View reviewed changes
output/baseoutput/clientsession.go Outdated Show resolved Hide resolved
@jiping-s @nemobis
@jstaffans @PedroTrigueros
output: Add fast shutdown, max session duration. Rename metric labels.
5c7fb83 
Co-authored-by: Federico Leva <federico.leva@relexsolutions.com>
Co-authored-by: Johannes Staffans <johannes.staffans@relexsolutions.com>
Co-authored-by: Pedro Trigueros <pedro.trigueros@relexsolutions.com>
@jiping-s jiping-s merged commit a8313bc into master Sep 30, 2021
@jiping-s jiping-s deleted the workshop3 branch September 30, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstaffans jstaffans jstaffans approved these changes

@PedroTrigueros PedroTrigueros PedroTrigueros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jiping-s @jstaffans @PedroTrigueros