Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicitly concatenated strings #80

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Jul 12, 2022

Fix strings like:

"Your package does neither have a license field " "nor any license classifiers."

To:

"Your package does neither have a license field nor any license classifiers."

These are often a by-product of running Black for the first time on a codebase.

(Found by running https://github.com/flake8-implicit-str-concat/flake8-implicit-str-concat)

Copy link
Collaborator

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, enabling ESP in Black (now under the --preview flag) should fix these instances automatically, no?

pyroma/projectdata.py Outdated Show resolved Hide resolved
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk
Copy link
Collaborator Author

hugovk commented Aug 18, 2022

FYI, enabling ESP in Black (now under the --preview flag) should fix these instances automatically, no?

What's ESP?

Ah yes, black --preview cleans these up, that's nice :) Hopefully it'll make Black v23.

@CAM-Gerlach
Copy link
Collaborator

What's ESP?

Experimental string processing, sorry, now apparently called Improved string processing

Ah yes, black --preview cleans these up, that's nice :) Hopefully it'll make Black v23.

That's tracked in psf/black#2188 , FWIW

Copy link
Collaborator

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit that I missed before, sorry, otherwise LGTM (again 😅 )

pyroma/projectdata.py Show resolved Hide resolved
@regebro regebro merged commit 2c0c3fb into regebro:master Aug 25, 2022
@hugovk hugovk deleted the fix-implicitly-concatenated-strings branch August 25, 2022 12:08
regebro pushed a commit that referenced this pull request Nov 24, 2022
* Fix implicitly concatenated strings

* Use f-string

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@regebro
Copy link
Owner

regebro commented Nov 24, 2022

@hugovk Hey, thanks for the help with Pyroma, I don't have your email, so I'm messaging you here. :-) I took the liberty to add you as a collaborator so you can review (and I think even merge, but I'm not sure) things. Thanks again!

@hugovk
Copy link
Collaborator Author

hugovk commented Nov 24, 2022

Collaborator isn't required for reviews but is for merge. Accepted, thanks!

@CAM-Gerlach
Copy link
Collaborator

PEP Editor, Python Core Dev sprint, CPython, and now Pyroma...it seems I can't escape @hugovk anywhere I go! 😂

@hugovk
Copy link
Collaborator Author

hugovk commented Nov 27, 2022

Ha, there's no escape! 🎣

As noted I'm quite active all over the place, so just to set expectations, I don't plan to be especially active here but happy to help out where I can with general maintenance stuff. 👍

@CAM-Gerlach
Copy link
Collaborator

Hey, you said that when we invited you to be a PEP editor but you're the second most active contributor to the repository in the past year...following closely behind me as usual 🕵️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants