-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implicitly concatenated strings #80
Fix implicitly concatenated strings #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, enabling ESP in Black (now under the --preview
flag) should fix these instances automatically, no?
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
What's ESP? Ah yes, |
Experimental string processing, sorry, now apparently called Improved string processing
That's tracked in psf/black#2188 , FWIW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit that I missed before, sorry, otherwise LGTM (again 😅 )
* Fix implicitly concatenated strings * Use f-string Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk Hey, thanks for the help with Pyroma, I don't have your email, so I'm messaging you here. :-) I took the liberty to add you as a collaborator so you can review (and I think even merge, but I'm not sure) things. Thanks again! |
Collaborator isn't required for reviews but is for merge. Accepted, thanks! |
PEP Editor, Python Core Dev sprint, CPython, and now Pyroma...it seems I can't escape @hugovk anywhere I go! 😂 |
Ha, there's no escape! 🎣 As noted I'm quite active all over the place, so just to set expectations, I don't plan to be especially active here but happy to help out where I can with general maintenance stuff. 👍 |
Hey, you said that when we invited you to be a PEP editor but you're the second most active contributor to the repository in the past year...following closely behind me as usual 🕵️ |
Fix strings like:
To:
"Your package does neither have a license field nor any license classifiers."
These are often a by-product of running Black for the first time on a codebase.
(Found by running https://github.com/flake8-implicit-str-concat/flake8-implicit-str-concat)