Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting a custom http agent #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steelbrain
Copy link

This PR adds a new setHttpAgent method to the API that sets the options.agent for requests.

The name is inspired from a similar method in stripe-node but I am open to changing it for a better name

@rlopzc
Copy link

rlopzc commented Jan 18, 2019

Hello @steelbrain

Why do you want to set a custom http agent? Is there an specific use case?

@steelbrain
Copy link
Author

@romariolopezc This is required for when a business does not want to store things like service credentials themselves, and has a reverse proxy that strips creds -> own servers -> forward proxy that injects creds like VGS.

While reverse proxy works by pointing client side apps to VGS, forward proxy needs to be an http agent on the requests. Adding this in Regaliator would allow Regalii usage in such setups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants