feat(middleware): Add support for Middleware to SSR-Streaming server #9883

dac09 · 2024-01-25T11:23:04Z

This is a first pass at introducing middleware into the streaming server, so we can do auth on the server!

Very poor quality audio whistle stop tour of how we'd be using this: https://s.tape.sh/iMAq52op?s=1.25

Includes:

MiddlewareResponse, MiddlewareRequest and CookieJar classes - that make dealing with the request more ergonomic
Adds a ServerAuthProvider, that will use the auth context set by auth middleware
Forwards on cookies from the browser when making a graphql request on the server (during cell SSR)
Restoring the auth state from the server - to save one extra API call, and to prevent React hydration errors

Outstanding:

Dependant on issue in whatwg-node here: Initatiating PonyfillRequest with another PonyfillRequest misses properties in the constructor ardatan/whatwg-node#1109
Add more tests
Actually implement calling the middleware properly

Add serverAuthState

WIP: still failing with ArdaRequest

…dleware * 'main' of github.com:redwoodjs/redwood: chore(structure): switch to vitest (redwoodjs#9878) chore(cli): switch to vitest (redwoodjs#9863) feat(dbAuth): Refactor dbAuthHandler to support WebAPI Request events (redwoodjs#9835) fix(crwa): remove yarn-install option for yarn 1 (redwoodjs#9881) chore(esbuild): dedupe esbuild config (redwoodjs#9875) chore(esm): convert `@redwoodjs/cli-helpers` to ESM (redwoodjs#9872) fix(studio): Add version checks when first running Studio (redwoodjs#9876)

CookieJar clearing a cookie

WIP: Why is vitest failing?

packages/auth/src/AuthProvider/AuthProvider.tsx

packages/auth/src/AuthProvider/ServerAuthProvider.tsx

packages/vite/src/devFeServer.ts

Tobbe · 2024-01-29T09:36:38Z

packages/auth/src/AuthProvider/ServerAuthProvider.tsx

+}) => {
+  // @NOTE: we "Sanitize" to remove encryptedSession and cookieHeader
+  // not totally necessary, but it's nice to not have them in the DOM
+  // @MARK: needs discussion!


What needs discussion? Can you and I discuss? I want to resolve this before merging

I just want to call this out for awareness. It's harmless right now, but its possible a contribution or new code could leak information here.

packages/vite/src/middleware/CookieJar.ts

packages/vite/src/middleware/MiddlewareRequest.ts

packages/vite/src/streaming/createReactStreamingHandler.ts

packages/web/src/apollo/suspense.tsx

packages/auth/src/AuthProvider/AuthProvider.tsx

packages/web/src/apollo/links.tsx

Updates comments, some types Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

More comment tings Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

…eat/ssr-middleware * 'feat/ssr-middleware' of github.com:dac09/redwood: Apply suggestions from Tobbe's review Apply suggestions from Tobbe's review Update installation.md (redwoodjs#9887)

packages/auth/src/AuthProvider/AuthProvider.tsx

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

…eat/ssr-middleware * 'feat/ssr-middleware' of github.com:dac09/redwood: Update packages/auth/src/AuthProvider/AuthProvider.tsx

packages/auth/src/AuthProvider/ServerAuthProvider.tsx

dac09 added 25 commits January 24, 2024 17:14

Add code for invoking middleware (WIP)

a560620

Add serverAuthState

Fix links in suspense apollo provider for backwards compatibility

17ab5f7

WIP: Start adding MW classes

84279f7

Use subclassing to create MiddlewareRequest

f0e0f38

WIP: still failing with ArdaRequest

WIP: Try extending WhatwgRequest instead

07207bc

Bump whatwg versions

eec9e3e

Add some more tests for MWReq, MWRes

8d64b1c

Update packages to make tests pass

7e51740

CookieJar unsetting a cookie

29cebfd

CookieJar clearing a cookie

Add test for multiple set cookies

65f221a

Remove old encrypted session from ServerAuthState

4a82d78

Export middleware classes

85ba98c

Fix TS errors in apollo

e579c9d

Improve implementations of mwReq and mwRes

93eaadd

Use classes while invoking middleware

9c01b3e

Update mRes implementation

57e7cb4

WIP: Why is vitest failing?

Consistent version of whatwg fetch

8090968

Readd commented line

cc16e07

Add test for constructor and perm redirects

9b27895

Send Response back from rwmw endpoint

bfb39ff

Default auth state in serverAuthContext

4717aae

Comment

47705c2

Move credentials include

30759dd

Merge branch 'main' into feat/ssr-middleware

9dff2d9

dac09 marked this pull request as ready for review January 26, 2024 14:51

dac09 added this to the SSR milestone Jan 26, 2024

dac09 added the release:feature This PR introduces a new feature label Jan 26, 2024

dac09 added 2 commits January 26, 2024 22:09

Update yarn.lock

9182742

Merge branch 'main' into feat/ssr-middleware

0029c2c

Tobbe requested changes Jan 29, 2024

View reviewed changes

Tobbe reviewed Jan 29, 2024

View reviewed changes

packages/auth/src/AuthProvider/AuthProvider.tsx Outdated Show resolved Hide resolved

Tobbe reviewed Jan 29, 2024

View reviewed changes

packages/web/src/apollo/links.tsx Show resolved Hide resolved

dac09 and others added 4 commits January 30, 2024 12:45

Cleanup comments in AuthProvider

20b18d8

Apply suggestions from Tobbe's review

ac82e57

Updates comments, some types Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Apply suggestions from Tobbe's review

2a5b72d

More comment tings Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Merge branch 'feat/ssr-middleware' of github.com:dac09/redwood into f…

6e89b52

…eat/ssr-middleware * 'feat/ssr-middleware' of github.com:dac09/redwood: Apply suggestions from Tobbe's review Apply suggestions from Tobbe's review Update installation.md (redwoodjs#9887)

Tobbe reviewed Jan 30, 2024

View reviewed changes

packages/auth/src/AuthProvider/AuthProvider.tsx Outdated Show resolved Hide resolved

dac09 and others added 5 commits January 30, 2024 15:14

Update packages/auth/src/AuthProvider/AuthProvider.tsx

5b46aec

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Implement middleware invoke helper

78879a6

Merge branch 'feat/ssr-middleware' of github.com:dac09/redwood into f…

3d14b51

…eat/ssr-middleware * 'feat/ssr-middleware' of github.com:dac09/redwood: Update packages/auth/src/AuthProvider/AuthProvider.tsx

Rename cookieJar.delete to unset

dcc50df

Also invoke middleware in prod fe server

a203a19

dac09 commented Jan 30, 2024

View reviewed changes

packages/auth/src/AuthProvider/ServerAuthProvider.tsx Outdated Show resolved Hide resolved

Update packages/auth/src/AuthProvider/ServerAuthProvider.tsx

beef260

Tobbe approved these changes Jan 30, 2024

View reviewed changes

Merge branch 'main' into feat/ssr-middleware

fda6e53

Tobbe enabled auto-merge (squash) January 31, 2024 03:38

Tobbe added 2 commits January 31, 2024 05:48

fix syntax error (extra })

967a6c2

Use relative import path

68250c2

Tobbe merged commit ff7d79c into redwoodjs:main Jan 31, 2024
38 checks passed

dac09 deleted the feat/ssr-middleware branch January 31, 2024 06:09

Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(middleware): Add support for Middleware to SSR-Streaming server #9883

feat(middleware): Add support for Middleware to SSR-Streaming server #9883

dac09 commented Jan 25, 2024 •

edited

Loading

Tobbe Jan 29, 2024

dac09 Jan 30, 2024

feat(middleware): Add support for Middleware to SSR-Streaming server #9883

feat(middleware): Add support for Middleware to SSR-Streaming server #9883

Conversation

dac09 commented Jan 25, 2024 • edited Loading

Tobbe Jan 29, 2024

Choose a reason for hiding this comment

dac09 Jan 30, 2024

Choose a reason for hiding this comment

dac09 commented Jan 25, 2024 •

edited

Loading