fix(vite): correctly parse --open from forwarded args

[jtoar]

Fixes an issue with our experimental Docker setup.

If browser.open is set to true (which it is by default) in a user's redwood.toml, docker compose -f docker-compose.dev.yml up (which is basically yarn rw dev) breaks:

Vite can't find a binary it needs to open the browser. The solution is telling Vite not to open the browser (it's running in a container). Since --fwd was never implemented for Vite, right now yarn rw exp setup-docker codemods the toml file:

This is overkill but more importantly it's not a great user experience. It'd be better to just pass --fwd="--open=false" in the Docker compose file.

At first I wanted to solve this by swapping rw-vite-dev for the Vite CLI, but since we handle env vars differently, we can't because the Vite CLI doesn't have an option for disabling env files. I.e. there's no Vite CLI option for this:

redwood/packages/vite/bins/rw-vite-dev.mjs

Line 29 in 43227f3

envFile: false, // env file is handled by plugins in the redwood-vite plugin

We could see about adding that to Vite. But for right now, let's at least parse --fwd="--open".

[jtoar]

Not working yet; seems like this line in the plugin is taking precedence over the config in rw-vite-dev:

redwood/packages/vite/src/index.ts

Line 192 in 43227f3

open: rwConfig.browser.open,

[Tobbe]

We could see about adding that to Vite.

This got me interested 🙂

So it would probably not be too hard. Here's probably a good entry point: https://github.com/vitejs/vite/blob/b93dfe3e08f56cafe2e549efd80285a12a3dc2f0/packages/vite/src/node/cli.ts#L125

But looking around I found this [1]:

This feature is primarily for frameworks that use Vite under the hood:

• Frameworks might need to load .env before starting Vite dev server, so they use the loadEnv function provided by Vite.
• Vite loads .env again when it's unnecessary
• Vite restarts when .env changes but this should be left to user in this case

That last bullet point caught my attention. They say that if you're using envFile: false (like we are) you're responsible for reloading when the env vars changes. Do we currently do that? And if we just used the Vite cli directly with --env-file=false, how would we handle the reloading?

[1] vitejs/vite#2475

[jtoar]

I think the next the todo here is to make this an issue and add the help wanted label.

Update: see #9209.