Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Added page for using GitPod to the documentation #9366

Merged
merged 11 commits into from
Jul 20, 2024

Conversation

ahaywood
Copy link
Contributor

@ahaywood ahaywood commented Oct 31, 2023

Feature description

  • Added information about using Redwood in GitPod on the Getting started page of the documentation
  • Added a dedicated page to the documentation for working with GitPod

@ahaywood
Copy link
Contributor Author

The images that I reference within the dedicated GitPod page are pointing to the images on the redwoodjs/starter repo

Question: This makes sense since this page of documentation is dependent on that repo. If the images in the starter repo change then should change within the documentation too. However, this also seems fragile and a point of failure. Should I duplicate the images, placing them in both repos?

Copy link

@ahaywood ahaywood changed the title 📝 WIP: Added page for using GitPod to the documentation 📝 Added page for using GitPod to the documentation Dec 20, 2023
@ahaywood ahaywood requested review from Tobbe and jtoar December 20, 2023 21:40
@jtoar jtoar added the release:docs This PR only updates docs label Dec 20, 2023
@jtoar jtoar added this to the next-release milestone Dec 20, 2023
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahaywood nice! Left some comments; may seem like a lot but it's mostly

  • consistent GitPod casing (the majority of comments)
  • some images/buttons don't seem to be rendering (included screenshots where appropriate)

I merged main into your branch so that I could get deploy previews going here: https://deploy-preview-9366--redwoodjs-docs.netlify.app/docs/canary/how-to/using-gitpod.

docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/how-to/using-gitpod.md Outdated Show resolved Hide resolved
docs/docs/quick-start.md Outdated Show resolved Hide resolved
@Tobbe
Copy link
Member

Tobbe commented Jun 26, 2024

@ahaywood Is this still relevant? If it is, do you need any help getting it merged?

@Josh-Walker-GM Josh-Walker-GM removed the request for review from Tobbe July 19, 2024 23:57
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I implemented Dom's suggestions and walked through the process. I had to update the starter repo to bump the version of node used to v20 but otherwise went great.

@Josh-Walker-GM Josh-Walker-GM merged commit ab07760 into redwoodjs:main Jul 20, 2024
45 checks passed
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants