-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Added page for using GitPod to the documentation #9366
Conversation
The images that I reference within the dedicated GitPod page are pointing to the images on the redwoodjs/starter repo Question: This makes sense since this page of documentation is dependent on that repo. If the images in the starter repo change then should change within the documentation too. However, this also seems fragile and a point of failure. Should I duplicate the images, placing them in both repos? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahaywood nice! Left some comments; may seem like a lot but it's mostly
- consistent GitPod casing (the majority of comments)
- some images/buttons don't seem to be rendering (included screenshots where appropriate)
I merged main into your branch so that I could get deploy previews going here: https://deploy-preview-9366--redwoodjs-docs.netlify.app/docs/canary/how-to/using-gitpod.
@ahaywood Is this still relevant? If it is, do you need any help getting it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I implemented Dom's suggestions and walked through the process. I had to update the starter repo to bump the version of node used to v20 but otherwise went great.
Feature description