Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storybook-vite] Ignore auto-generated auto-imports.d.ts #11589

Closed
wants to merge 1 commit into from

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Sep 19, 2024

After having upgraded to RW 7.7.4 and migration storybook to vite, i noticed the unintentionally checked-in file web/src/auto-imports.d.ts.

So this should be part of the storybook → vite migration.

@ahaywood
Copy link
Contributor

ahaywood commented Sep 19, 2024

@Philzen Thanks for contributing! @arimendelow Would you mind reviewing, there might be some overlay with your #11581 PR?

@arimendelow
Copy link
Contributor

Hello!! #11581 is just some simple docs links updates — @Philzen, if you upgrade further, you'll see that we no longer generate this file. This was fixed on this line here:

I'm not sure exactly what version this correlates to (PR is from a couple months back) — if you upgrade to v8 you should be good to go :)

@Philzen
Copy link
Contributor Author

Philzen commented Sep 19, 2024

Ah i see, the change you linked was first shipped with v8.0.0-rc.1114.

So i guess this is not relevant anymore, except for folks being at v7 with storybook-vite. Closing then.

@Philzen Philzen closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants