Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(uploads): Tweaks from updating the Recipes example app #11571

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Sep 16, 2024

Fix file paths

The contrast here makes it difficult to read the comment. So I kept the highlighted line, but moved the comment to the line above. (And in general I'm not a big fan of long end-of-line comments anyway)
image

Toggle file extension depending on if the user prefers JS or TS

Add example of how to construct a public URL to uploaded files

@Tobbe Tobbe added the release:docs This PR only updates docs label Sep 16, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Sep 16, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label Sep 16, 2024
@Tobbe Tobbe merged commit 7173844 into redwoodjs:main Sep 16, 2024
55 of 63 checks passed
@Tobbe Tobbe deleted the tobbe-uploads-storage-docs branch September 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants