chore(linting): Re-enable some ts-eslint rules #11256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:chore
|
We should revisit the cases here where I have added the disable directives. I don't want to introduce a breaking type change here without complete confidence. Enabling the rule even with these exceptions will help prevent more additions over time. I'll merge this now and continue on with some more updates. |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 15, 2024
…o try/apollo-upload-link * 'try/apollo-upload-link' of github.com:dac09/redwood: chore(linting): enable type checked linting (redwoodjs#11258) chore(lint): lint config refactoring and re-enable some stylistic rules (redwoodjs#11257) chore(linting): Re-enable some ts-eslint rules (redwoodjs#11256) feat(rsc): Register top-level function-scoped RSAs (redwoodjs#11255) chore(lint): refactor react, react-hooks and ts-eslint usage (redwoodjs#11254) chore(formatting): Add prettier check to CI (redwoodjs#11253) chore(formatting): Formatting 2 of n (redwoodjs#11252) chore(formatting): Formatting 1 of n (redwoodjs#11251) chore(formatting): Format readme files (redwoodjs#11248) chore(record): Remove used file (redwoodjs#11247) chore(formatting): Remove 'insert_final_newline' from editor config (redwoodjs#11249) chore(lint): Split linting and formatting (redwoodjs#11246)
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 15, 2024
* 'main' of github.com:redwoodjs/redwood: (37 commits) chore(linting): enable type checked linting (redwoodjs#11258) chore(lint): lint config refactoring and re-enable some stylistic rules (redwoodjs#11257) chore(linting): Re-enable some ts-eslint rules (redwoodjs#11256) feat(rsc): Register top-level function-scoped RSAs (redwoodjs#11255) chore(lint): refactor react, react-hooks and ts-eslint usage (redwoodjs#11254) chore(formatting): Add prettier check to CI (redwoodjs#11253) chore(formatting): Formatting 2 of n (redwoodjs#11252) chore(formatting): Formatting 1 of n (redwoodjs#11251) chore(formatting): Format readme files (redwoodjs#11248) chore(record): Remove used file (redwoodjs#11247) chore(formatting): Remove 'insert_final_newline' from editor config (redwoodjs#11249) chore(lint): Split linting and formatting (redwoodjs#11246) chore(linting): Remove/fix references to non-existant files (redwoodjs#11245) chore(rsa): Use swc for parsing server actions (redwoodjs#11243) chore(lint): Remove override for 'unused-imports/no-unused-imports' (redwoodjs#11244) chore(linting): Separate out framework and user linting config (redwoodjs#11242) fix: Update default tsconfig options (target, module and moduleResolution) (redwoodjs#11170) chore(fixture): Update tailwind dep (redwoodjs#11241) chore(deps): bump fast-xml-parser from 4.4.0 to 4.4.1 (redwoodjs#11239) chore(rsc): Switch last remaining transform-server test to inline snapshot (redwoodjs#11240) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the eslint config to re-enable some of the recommended rules which had been disable.
This PR does change types but my hope is that they aren't functional changes so will not be breaking or have an effect.