fix(deps): update typescript-eslint monorepo to v8 (major) #11235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:breaking
Josh-Walker-GM
commented
Aug 13, 2024
Comment on lines
+45
to
+51
| { | ||
| files: ['*.ts', '*.tsx'], | ||
| rules: { | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/consistent-type-imports': 'error', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I moved these from the generic "rules" above because otherwise there was errors related to passing config through the babel parser to the ts-eslint parser
There was a problem hiding this comment.
Do we care about .mts? No biggie either way
There was a problem hiding this comment.
Yeah good spot! I noticed that in some of the tinkering I did earlier today outside this PR. I'll make sure to add this in some follow up work.
Josh-Walker-GM
commented
Aug 13, 2024
| @@ -154,7 +154,8 @@ module.exports = { | |||
| // 'recommended' rules we alter | |||
| '@typescript-eslint/no-explicit-any': 'warn', | |||
| '@typescript-eslint/no-var-requires': 'off', | |||
| '@typescript-eslint/ban-types': 'warn', | |||
| '@typescript-eslint/no-require-imports': 'off', | |||
| '@typescript-eslint/no-empty-object-type': 'off', | |||
There was a problem hiding this comment.
I have turned this off just for the moment. It will be turned back on once I follow up with a PR to update the framework side config.
Josh-Walker-GM
commented
Aug 13, 2024
| @@ -154,7 +154,8 @@ module.exports = { | |||
| // 'recommended' rules we alter | |||
| '@typescript-eslint/no-explicit-any': 'warn', | |||
| '@typescript-eslint/no-var-requires': 'off', | |||
| '@typescript-eslint/ban-types': 'warn', | |||
| '@typescript-eslint/no-require-imports': 'off', | |||
There was a problem hiding this comment.
The no-var-requires above is now deprecated in favour of this rule. I have left the original in for the moment and matched it's level.
dac09
approved these changes
Aug 13, 2024
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 14, 2024
…pload-link * 'main' of github.com:redwoodjs/redwood: chore(linting): Remove/fix references to non-existant files (redwoodjs#11245) chore(rsa): Use swc for parsing server actions (redwoodjs#11243) chore(lint): Remove override for 'unused-imports/no-unused-imports' (redwoodjs#11244) chore(linting): Separate out framework and user linting config (redwoodjs#11242) fix: Update default tsconfig options (target, module and moduleResolution) (redwoodjs#11170) chore(fixture): Update tailwind dep (redwoodjs#11241) chore(deps): bump fast-xml-parser from 4.4.0 to 4.4.1 (redwoodjs#11239) chore(rsc): Switch last remaining transform-server test to inline snapshot (redwoodjs#11240) chore: brought in typescript-eslint@v8 with stylistic preset (redwoodjs#10911) chore(deps): bump axios from 1.7.3 to 1.7.4 (redwoodjs#11237) docs(serverConfig): Remove server config option from TOML (redwoodjs#11236) fix(deps): update typescript-eslint monorepo to v8 (major) (redwoodjs#11235)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #11234.
This will change user facing linting rules. From the changes I have seen I don't believe there are any rule changes here that we would want to override beyond those I have included in the PR.
Note my intention after this PR goes in is to split the framework and user facing linting rules into different configs - no shared config. I would then look to do further updates to the framework config.