fix(api-server): Use createServer in all cases, to make fastify config consistent #11176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
added
release:breaking
|
Josh noted that the PR removes support for server.config.js (because createServer does not use it) - which makes this a breaking change. I'll wait to merge this till I understand what our release plan is. |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 14, 2024
…pload-link * 'main' of github.com:redwoodjs/redwood: (56 commits) chore(deps): update babel monorepo (redwoodjs#11190) fix(deps): update dependency jscodeshift to v17 (redwoodjs#11233) chore(deps): update babel monorepo (redwoodjs#11228) chore(deps): update dependency @clerk/types to v3.65.3 (redwoodjs#11230) fix(deps): update dependency vite-plugin-cjs-interop to v2.1.2 (redwoodjs#11224) fix(deps): update graphql-tools monorepo (redwoodjs#11232) chore(deps): update dependency @clerk/clerk-react to v4.32.3 (redwoodjs#11229) fix(deps): update dependency @clerk/clerk-sdk-node to v4.13.21 (redwoodjs#11231) fix(deps): update dependency cheerio to v1.0.0 (redwoodjs#11218) chore(deps): update yarn to v4.4.0 (redwoodjs#11227) fix(deps): update dependency core-js to v3.38.0 (redwoodjs#11226) chore(deps): update eslint monorepo to v9.9.0 (redwoodjs#11202) fix(api-server): Use createServer in all cases, to make fastify config consistent (redwoodjs#11176) chore(deps): update dependency tsx to v4.17.0 (redwoodjs#11199) chore(deps): update dependency @types/vscode to v1.92.0 (redwoodjs#11193) fix(deps): update dependency @graphql-yoga/plugin-defer-stream to v3.6.3 (redwoodjs#11211) fix(deps): update dependency @graphql-yoga/plugin-persisted-operations to v3.6.3 (redwoodjs#11213) chore(deps): update dependency eslint-plugin-perfectionist to v3.1.3 (redwoodjs#11195) chore(deps): update dependency eslint-plugin-jsdoc to v48.11.0 (redwoodjs#11194) chore(deps): update dependency @playwright/test to v1.46.0 (redwoodjs#11191) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the cases where we use
createFastifyInstancefor the api server, and replaces it withcreateServer.This makes sure that the API server config is always consistent - whether you use a server file or not.
The cases where I've tested:
.... missing anything?