Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crwrsca): Fix handling of positional args #11138

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Aug 1, 2024

If the user does crwrsca --template template-name ~/tmp/rw-crwrsca-app we'd find "template-name" as the first positional argument. But obviously that's connected to --template and shouldn't be used as the installation dir. The correct installation dir is ~/tmp/rw-crwrsca-app.
This PR fixes this cli args parsing bug

@Tobbe Tobbe added the release:fix This PR is a fix label Aug 1, 2024
@Tobbe Tobbe added this to the chore milestone Aug 1, 2024
@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) and removed release:fix This PR is a fix labels Aug 1, 2024
@Tobbe Tobbe merged commit 3f475ac into redwoodjs:main Aug 1, 2024
52 of 56 checks passed
@Tobbe Tobbe deleted the tobbe-crwrsca-fix-install-path-bug branch August 1, 2024 12:48
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants