Disable unused imports/ vars/ params in TypeScript compiler, opt for ESLint instead #11125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm coding against the framework I'm often leaving the files in a "dirty state" in order to validate an idea. They're not logical errors, but merely unused imports, variables and parameters. This often leaves me having to comment out large swathes of code to test my idea and slows me down!
I polled the core contributors and the majority agreed that this would be helpful, so in this PR I disable the unused variable checking in TypeScript and make ESLint check for it instead.