Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tsconfig.types-cjs): Specify tsBuildInfoFile location #10950

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 15, 2024

If we don't specify the location it'll end up in dist/ (<outdir>/../) and be included in our packages, which we don't want.

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 15, 2024
@Tobbe Tobbe added this to the chore milestone Jul 15, 2024
@Tobbe Tobbe merged commit d468192 into redwoodjs:main Jul 15, 2024
51 of 59 checks passed
@Tobbe Tobbe deleted the tobbe-types-cjs-ts-config branch July 15, 2024 13:53
dac09 added a commit to dac09/redwood that referenced this pull request Jul 16, 2024
…g-dual

* 'main' of github.com:redwoodjs/redwood:
  fix(web): Re-add generating ESM types (redwoodjs#10952)
  chore(project-config): Verify package.json with publint and attw (redwoodjs#10951)
  chore(apollo client): Add types for cjs imports (redwoodjs#10949)
  chore(tsconfig.types-cjs): Specify tsBuildInfoFile location (redwoodjs#10950)
dac09 added a commit to dac09/redwood that referenced this pull request Jul 16, 2024
…-mw-dualpkg

* 'main' of github.com:redwoodjs/redwood:
  RSC: Fix red squiggles in default template (redwoodjs#10955)
  chore(supabase-mw): Convert supabase-mw to dual package (redwoodjs#10954)
  chore(esm/cjs): Make the rwjs/vite package dual (redwoodjs#10934)
  chore(auth): More gracefully handle build failures (redwoodjs#10953)
  fix(web): Re-add generating ESM types (redwoodjs#10952)
  chore(project-config): Verify package.json with publint and attw (redwoodjs#10951)
  chore(apollo client): Add types for cjs imports (redwoodjs#10949)
  chore(tsconfig.types-cjs): Specify tsBuildInfoFile location (redwoodjs#10950)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants