Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(structure): Remove obsolete placeholder implementation #10923

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 8, 2024

We don't put pre-render info on the routes. (We use the routeHooks file for that). So the hasPreRenderInfo method should not exist on RWRoute.

(Instead, if/when we want to improve the diagnostics command we should have it look at the routeHooks file and map it to the routes and highlight in the metaData file if it's missing prerender data, or providing data to routes that don't accept it)

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 8, 2024
@Tobbe Tobbe added this to the chore milestone Jul 8, 2024
@Tobbe Tobbe enabled auto-merge (squash) July 8, 2024 11:54
@Tobbe Tobbe merged commit aa90b09 into redwoodjs:main Jul 8, 2024
51 of 58 checks passed
@Tobbe Tobbe deleted the tobbe-structure-remove-obsolete-method branch July 8, 2024 12:10
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants