Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use more supported syntax in publish_canary script #10915

Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 5, 2024

Switching to a more widely supported syntax in one of the commands in the publish_canary.sh script to more easily run/debug the script on everyones own computers.

We used to use |& which is just shorthand syntax for 2>&1 |

If ‘|&’ is used, command1’s standard error, in addition to its standard output, is connected to command2’s standard input through the pipe; it is shorthand for 2>&1 |. This implicit redirection of the standard error to the standard output is performed after any redirections specified by command1.

https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Pipelines

This shorthand syntax was added in bash 4.0.0 https://github.com/bminor/bash/blob/bash-4.0/CHANGES#L607
MacOS is still on bash 3.2

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 5, 2024
@Tobbe Tobbe added this to the chore milestone Jul 5, 2024
@Tobbe Tobbe merged commit 91f78fa into redwoodjs:main Jul 5, 2024
55 of 56 checks passed
@Tobbe Tobbe deleted the tobbe-chore-publish_canary_no_shorthand branch July 5, 2024 07:44
dac09 pushed a commit to dac09/redwood that referenced this pull request Jul 6, 2024
…iddleware

* 'main' of github.com:redwoodjs/redwood:
  chore(server-store): Alias imports for getting request details to  `@redwoodjs/web/request` (redwoodjs#10904)
  chore(ci): Cleaner log when publishing, unless failure (redwoodjs#10919)
  chore(tests): Fix failing kitchen-sink tests by logging in (redwoodjs#10920)
  fix(internal gql): Update types in test fixture (redwoodjs#10918)
  debug(ci): Print publishing command output (redwoodjs#10916)
  chore(ci): Use more supported syntax in publish_canary script (redwoodjs#10915)
  chore(ci): Exit canary publishing if version cannot be determined (redwoodjs#10914)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants