fix(realtime/trusted-docs): Supports GraphQL subscriptions and trusted documents #10893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dthyresson
changed the title
Josh-Walker-GM
approved these changes
Jul 1, 2024
Josh-Walker-GM
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10892
This PR updates the SSELink to check if there is a trusted document hash in the request. If there is, then don't also include the query.
The persisted operations plugin checks if the params has a query. If it does then raises an error that only persisted operations are allowed.
Subscriptions failed this test because the request had both the hash and a query. And since there were query details, the request was blocked.
Now, if there is a hash, the SSELink won't add back the query and thus it succeeds.