chore(esm/cjs): Build rwjs/web to cjs with new build system #10826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename files without JSX files to just ts
…ckage-cjsonly-new-build * 'main' of github.com:redwoodjs/redwood: (66 commits) chore(testing dbAuth): Add "yes" prompt testing for WebAuthn (redwoodjs#10823) chore(testing dbAuth): Mock console.log to silence test output (redwoodjs#10821) chore(testing dbAuth): Remove duplicated tests (redwoodjs#10822) chore(testing dbAuth): Remove outdated code (redwoodjs#10820) chore(testing dbAuth): Consistent naming and fix blue squiggles (redwoodjs#10819) chore(testing dbAuth): provide mock implementations (redwoodjs#10818) feat(dbAuth): Only suggest dbAuth setup if needed (redwoodjs#10793) chore(dbAuth): Fix test for webauthn prompt in `g dbAuth` (redwoodjs#10814) fix(dbAuth): Print the correct "post message" after generation (redwoodjs#10813) fix(dbauth): Fix spacing issue in task titles (redwoodjs#10811) deps(docs): update braces package (redwoodjs#10809) chore(deps): bump braces from 3.0.2 to 3.0.3 in /tasks/check (redwoodjs#10808) chore(deps): update yarn to v4.3.0 (redwoodjs#10801) chore(deps): update dependency tsx to v4.15.2 (redwoodjs#10800) chore(deps): update dependency @clerk/types to v3.65.2 (redwoodjs#10795) chore(deps): update dependency firebase to v10.12.2 (redwoodjs#10802) chore(deps): update dependency rollup to v4.18.0 (redwoodjs#10799) chore(deps): update dependency jsdom to v24.1.0 (redwoodjs#10798) chore(deps): update dependency @types/vscode to v1.90.0 (redwoodjs#10796) chore(deps): update dependency @clerk/clerk-react to v4.32.2 (redwoodjs#10794) ...
Josh-Walker-GM
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Nice, looks good to me. There appear to be 4 files deleted from the dist but there are all test files which should never have been there to start with. CI being green is confidence enough for me with the dist having the same files. Looking forward to moving more of our code over and then to esm.
2 tasks
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 24, 2024
…-esm * 'main' of github.com:redwoodjs/redwood: fix(deps): update dependency prettier to v3.3.2 (redwoodjs#10852) fix(deps): update dependency vite to v5.3.1 (redwoodjs#10854) chore(esm/cjs): Build rwjs/web to cjs with new build system (redwoodjs#10826) feat(dbAuth): Automatically create User model in fresh projects (redwoodjs#10871) feat(dbAuth): Prompt to generate dbAuth pages (redwoodjs#10865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps the babel build process for esbuild, as a first step of converting the web package to ESM/CJS.
In order to get this to work I had to manually import React in all of the source files with JSX, as it was being autoimported by a babel plugin. I think this is better than just adding another plugin to our build step (keep it vanilla!)
Tested with auth
✅ legacy
✅ ssr-streaming
Tested with kitchen sink
✅ RSC
Note:
I had to change the "remove from bundle" plugin. It took a lot of experimentation, but switching to esm syntax seems to fix it in all cases.