Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Storybook Vite unit tests #10768

Merged
merged 27 commits into from
Jul 24, 2024
Merged

Add Storybook Vite unit tests #10768

merged 27 commits into from
Jul 24, 2024

Conversation

arimendelow
Copy link
Contributor

@arimendelow arimendelow commented Jun 9, 2024 •
edited
Loading

Adds:

  • Smoke tests for Add Storybook (Vite) framework package #10064 based on the existing smoke tests for Storybook Webpack, with minimal changes.
  • Small bug fix where Storybook doesn't fully load on first run (found during smoke tests development)
  • Unit tests for storybook-vite CLI (based on those from the dataMigrate CLI)

@arimendelow arimendelow marked this pull request as draft June 11, 2024 03:42
@arimendelow arimendelow changed the title Add Storybook Vite smoke tests Add Storybook Vite tests (smoke + unit) Jun 11, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jul 16, 2024
@Josh-Walker-GM Josh-Walker-GM mentioned this pull request Jul 18, 2024
Merged
Josh-Walker-GM added a commit that referenced this pull request Jul 18, 2024
@Josh-Walker-GM
fix(storybook): Fix import issues with storybook vite (#10961)
065e6e6 
I was seeing issues with the storybook vite command. It would complain
about `default` with imports.

I have reverted some of your changes here @dac09. Hopefully this is
okay? I didn't have a lot of context around the original changes you
made but I have reverted here because it fixes the issue I was seeing.
Happy for you to correct me if I am taking us in the wrong direction.

I also stole some code from #10768.
@Josh-Walker-GM
Copy link
Collaborator

Small bug fix where Storybook doesn't fully load on first run (found during smoke tests development)

I stole that and included it in #10961

@arimendelow arimendelow marked this pull request as ready for review July 19, 2024 22:45
Tobbe
Tobbe reviewed Jul 20, 2024
View reviewed changes
.changesets/10768.md Outdated Show resolved Hide resolved
@Josh-Walker-GM Josh-Walker-GM self-requested a review July 20, 2024 23:35
arimendelow and others added 2 commits July 22, 2024 17:24
@arimendelow @Tobbe
Update .changesets/10768.md
1ec0e16 
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
@arimendelow
Merge branch 'main' of https://github.com/redwoodjs/redwood into ari/…
41e9ee4 
…storybook-tests
@arimendelow arimendelow requested a review from Tobbe July 23, 2024 00:29
@Josh-Walker-GM Josh-Walker-GM added this to the chore milestone Jul 23, 2024
@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jul 23, 2024
@Josh-Walker-GM Josh-Walker-GM changed the title Add Storybook Vite tests (smoke + unit) Add Storybook Vite unit tests Jul 23, 2024
Josh-Walker-GM
Josh-Walker-GM approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the existing storybook webpack smoke tests with the vite ones in #10867 so I removed the additional duplicate copy from this PR.

@arimendelow Let me know if you agree with the changes I've pushed up and then we can merge this in if you're happy.

@arimendelow
Copy link
Contributor Author

I replaced the existing storybook webpack smoke tests with the vite ones in #10867 so I removed the additional duplicate copy from this PR.

@arimendelow Let me know if you agree with the changes I've pushed up and then we can merge this in if you're happy.

i was actually wondering about that because i remember you mentioned it in our call — sounds good :)

@Tobbe Tobbe merged commit 7565437 into redwoodjs:main Jul 24, 2024
42 checks passed
@arimendelow arimendelow deleted the ari/storybook-tests branch July 25, 2024 20:31
@arimendelow arimendelow restored the ari/storybook-tests branch July 25, 2024 20:57
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobbe Tobbe Tobbe approved these changes

@Josh-Walker-GM Josh-Walker-GM Josh-Walker-GM approved these changes

Assignees

@Josh-Walker-GM Josh-Walker-GM

Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arimendelow @Josh-Walker-GM @Tobbe