Small edits on the trusted documents page #10745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @benjie - changes look correct to me, but will @dthyresson verify and merge ✌️ |
Josh-Walker-GM
added
the
contributor-pr
Josh-Walker-GM
added
release:docs
dthyresson
reviewed
Jun 18, 2024
| @@ -4,7 +4,7 @@ RedwoodJS can be setup to enforce [persisted operations](https://the-guild.dev/g | |||
|
|
|||
| Use trusted documents if your GraphQL API is only for your own app (which is the case for most GraphQL APIs) for a massively decreased attack-surface, increased performance, and decreased bandwidth usage. | |||
|
|
|||
| At app build time, Redwood will extract the GraphQL documents (queries, etc) and make them available to the server. At run time, you can then send "document id" or "hash" instead of the whole document; only accept requests with a known document id. | |||
| At app build time, Redwood will extract the GraphQL documents (queries, etc) and make them available to the server. At run time, you must then send "document id" or "hash" instead of the whole document as the server will only accept requests with a known document id. | |||
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Jun 25, 2024
Super happy that you're making trusted documents so easy to use! Whilst reviewing the text I spotted a few typos and awkward sentences so here are some minor edits ❤️ Line 7 you should review carefully, I've significantly changed the meaning of the sentence, so if I'm mistaken please correct me. Co-authored-by: David Thyresson <dthyresson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super happy that you're making trusted documents so easy to use! Whilst reviewing the text I spotted a few typos and awkward sentences so here are some minor edits ❤️
Line 7 you should review carefully, I've significantly changed the meaning of the sentence, so if I'm mistaken please correct me.