Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client-entry): Slight tweaks around entry.client handling #10741

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 6, 2024

I was trying to better understand how entry.client.tsx was used during SSR, and when following the code I found a few things I wanted to change to, in my opinion, make the code easier to read, understand and follow.

Even though entry.server.tsx is the main entry point for SSR, we still need to read the client build manifest and find entry.client.tsx to get the correct links to insert for the initial CSS files the browser will eventually render when the finalized html output is being streamed to the browser. We also need it to tell React what JS bundle contains hydrateRoot when it'll eventually get to hydrating things in the browser

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jun 6, 2024
@Tobbe Tobbe added this to the RSC milestone Jun 6, 2024
@Tobbe Tobbe merged commit 1866d6f into redwoodjs:main Jun 6, 2024
51 checks passed
@Tobbe Tobbe deleted the tobbe-client-entry-tweaks branch June 6, 2024 12:31
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants