-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ssr/rsc): Update tsconfig when enabling streaming-ssr #10701
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ac9e441
chore(ssr/rsc): Update tsconfig when enabling streaming-ssr
dac09 130724c
Formatting
dac09 ced7747
Prettify crwa tsconfig.json
dac09 bb41caf
Construct tsConfig from base, setting jsconfig if js
dac09 acac3ff
Update test-project fixture with formatted tsconfig
dac09 f28993e
Merge branch 'main' into chore/update-tsconfig
Tobbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
packages/cli/src/commands/experimental/templates/streamingSsr/tsconfig.json.template
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "noEmit": true, | ||
| "allowJs": true, | ||
| "esModuleInterop": true, | ||
| "target": "esnext", | ||
| "module": "NodeNext", | ||
| "moduleResolution": "NodeNext", | ||
| "skipLibCheck": false, | ||
| "rootDirs": [ | ||
| "./src", | ||
| "../.redwood/types/mirror/web/src", | ||
| "../api/src", | ||
| "../.redwood/types/mirror/api/src" | ||
| ], | ||
| "paths": { | ||
| "src/*": [ | ||
| "./src/*", | ||
| "../.redwood/types/mirror/web/src/*", | ||
| "../api/src/*", | ||
| "../.redwood/types/mirror/api/src/*" | ||
| ], | ||
| "$api/*": [ | ||
| "../api/*" | ||
| ], | ||
| "types/*": [ | ||
| "./types/*", | ||
| "../types/*" | ||
| ], | ||
| "@redwoodjs/testing": [ | ||
| "../node_modules/@redwoodjs/testing/web" | ||
| ] | ||
| }, | ||
| "typeRoots": [ | ||
| "../node_modules/@types", | ||
| "./node_modules/@types", | ||
| "../node_modules/@testing-library" | ||
| ], | ||
| "types": [ | ||
| "jest", | ||
| "jest-dom", | ||
| "react/experimental" | ||
| ], | ||
| "jsx": "preserve" | ||
| }, | ||
| "include": [ | ||
| "src", | ||
| "config", | ||
| "../.redwood/types/includes/all-*", | ||
| "../.redwood/types/includes/web-*", | ||
| "../types", | ||
| "./types" | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please try to keep this file as close as possible to the template in CRWA? So that it's easier for users to see what changes the setup command actually did by just running a
git diff. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...
Why did you have to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. The CRWA template isn't formatted with prettier (which is why you see a big diff. I used prettier on all of the ones I changed.
Would you like me to prettify crwa or change all the others to the unformatted version?
(the ones in the fixture were paritally formatted and not confgruent with crwa)