Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): Refactor: Move analyzeRoutes to separate file #10535

Merged
merged 3 commits into from
May 3, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented May 3, 2024

The utils file was getting too large. And we already had the tests in a separate file because this really is such a distinct and important function that it deserves its own file!

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels May 3, 2024
@Tobbe Tobbe added this to the chore milestone May 3, 2024
@Tobbe Tobbe enabled auto-merge (squash) May 3, 2024 09:29
@Tobbe Tobbe merged commit e1e9171 into redwoodjs:main May 3, 2024
46 checks passed
@Tobbe Tobbe deleted the tobbe-router-refactor-analyze-routes branch May 3, 2024 11:59
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, RSC May 6, 2024
@Josh-Walker-GM
Copy link
Collaborator

I'm going to move this into RSC because that's how I labelled #10434 when I didn't cherry pick that one over. Perhaps not picking that one over is now coming back to bite me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants