feat(RSC): Remove entries.ts file
#10533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:feature
Josh-Walker-GM
force-pushed
the
jgmw/rsc-remove-entries-file
branch
from
dc96c12
to
bd5198e
Compare
Josh-Walker-GM
force-pushed
the
jgmw/rsc-remove-entries-file
branch
from
bd5198e
to
f63b99b
Compare
Josh-Walker-GM
commented
May 2, 2024
Tobbe
reviewed
May 2, 2024
Tobbe
reviewed
May 3, 2024
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 3, 2024
…dwood into feat/supabase-middleware-client * 'feat/supabase-middleware-client' of github.com:dac09/redwood: feat(RSC): Remove `entries.ts` file (redwoodjs#10533) testing to see if getToken is called Try to see if swapping getToken order mock passes Windows CI feat(server-auth): Refactor useReauthenticate to prevent double currentUser calls (redwoodjs#10531) chore(deps): update dependency rollup to v4.17.2 (redwoodjs#10346) fix(deps): update docusaurus monorepo to v3.2.1 (redwoodjs#10371)
Josh-Walker-GM
added a commit
that referenced
this pull request
May 7, 2024
#10549) **Problem** This is a follow up to #10533 which removed the need for the `entries.ts` file. That PR failed to remove the file from both the existing RSC test fixtures and the setup command. **Changes** 1. Removes the `entries.ts` file from the RSC test fixtures 2. Removes the step in the RSC setup command that adds the `entries.ts` file to a project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently require you to explicitly map certain names to import paths. For example between page names and page import paths. This is later used at dev or build time to stitch things together properly. This isn't great DX as we make the user essentially duplicate information that is present/known from the router.
Notes
Outstanding
1. This PR has a side effect of reserving theWe renamed it toServerEntryname. Adding a page called that would potentially cause issues as it would be overridden in thegetEntriesfunction.__rwjs__ServerEntryto mitigate this