feat: Remove --performance option from yarn rw build
#10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spoke with @Tobbe and we agreed to merge this for now. When the time comes to release this in the next major we have an opportunity to re-evaluate if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR removes the
--performanceflag from theyarn rw buildcommand. This also removes the associated logic, webpack config, and its associated dependency.Specifically
babel-timing. The GitHub repo has not been committed to in 3 years. The constraints it adds to resolving other dependencies are potentially holding back security-related dependency upgrades.Changes
--performanceflag and the logic performed when the flag was passed--performancebehaviourbabel-timingdependencyNotes
It is important to take into account the usage of this command when we consider removing it. From looking at our anonymised telemetry this flag has been used less than a dozen times in the last 6 months. Where it has been used it was used in projects that are using vite - the results of this flag are related to webpack builds not vite so this would be misleading/useless in this case anyway.