Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): refactor out set up steps #10249

Merged
merged 1 commit into from
Mar 17, 2024
Merged

chore(ci): refactor out set up steps #10249

merged 1 commit into from
Mar 17, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 17, 2024

Want to keep working on CI every now and then. Starting by cleaning up some things so it's easier to reason about. Most jobs run the following steps:

  • enable corepack (this should go away one day when the setup node action supports it)
  • set up node
  • enable corepack again (for windows)
  • set up yarn cache
  • yarn install
  • build

Refactoring these out into a composite action so that we can save some lines in ci.yml which is starting to get quite long. I can also document some things better this way.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Mar 17, 2024
@jtoar jtoar added this to the chore milestone Mar 17, 2024
@jtoar jtoar marked this pull request as ready for review March 17, 2024 17:07
@jtoar jtoar merged commit 9283e2b into main Mar 17, 2024
43 of 49 checks passed
@jtoar jtoar deleted the ds-ci/refactor-out-set-up branch March 17, 2024 17:07
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants