Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC: Use vite plugin to inject webpack shims #10245

Merged
merged 5 commits into from
Mar 17, 2024
Merged

RSC: Use vite plugin to inject webpack shims #10245

merged 5 commits into from
Mar 17, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Mar 17, 2024 •
edited
Loading

We were injecting shims into the SSR stream, but for SSR+RSC that's not early enough. They wouldn't be ready for SSR itself at that point

@Tobbe Tobbe added changesets-ok Override the changesets check release:fix This PR is a fix labels Mar 17, 2024
@Tobbe Tobbe added this to the RSC milestone Mar 17, 2024
@Tobbe Tobbe merged commit 6d7ab69 into redwoodjs:main Mar 17, 2024
44 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-webpack-shim branch March 17, 2024 09:33
Tobbe added a commit to Tobbe/redwood that referenced this pull request Mar 17, 2024
@Tobbe
RSC: Use vite plugin to inject webpack shims (redwoodjs#10245)
c06b2fe
@Tobbe Tobbe mentioned this pull request Mar 17, 2024
Merged
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM