Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC: Tweak comment in vite/client #10240

Merged
merged 1 commit into from
Mar 16, 2024
Merged

RSC: Tweak comment in vite/client #10240

merged 1 commit into from
Mar 16, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Mar 16, 2024 •
edited
Loading

Tweak comment re window === 'undefined' check

Should have been part of #10239

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Mar 16, 2024
@Tobbe Tobbe added this to the RSC milestone Mar 16, 2024
@Tobbe Tobbe merged commit 9ede22c into redwoodjs:main Mar 16, 2024
38 of 45 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-vite-client-comment branch March 16, 2024 16:24
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM