Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rsc): make change to run ci #10201

Closed
wants to merge 1 commit into from
Closed

chore(rsc): make change to run ci #10201

wants to merge 1 commit into from

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 11, 2024

Making a change to CI to test #10197 now that a canary has been published.

@jtoar jtoar added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Mar 11, 2024
@jtoar jtoar added this to the RSC milestone Mar 11, 2024
@jtoar jtoar mentioned this pull request Mar 11, 2024
Merged
@jtoar
Copy link
Contributor Author

jtoar commented Mar 11, 2024

Seems like I've sorted it out in #10202.

@jtoar jtoar closed this Mar 11, 2024
@jtoar jtoar deleted the ds-rsc/trigger-ci branch March 11, 2024 16:50
jtoar added a commit that referenced this pull request Mar 11, 2024
@jtoar
fix(rsc): try fixing dev (#10202)
edbbf7b 
Based on #10201, it looks like
CI wasn't correctly catching the errors in the [Vite v5
upgrade](#10197) as far as RSC
goes at least. Had some success with configuring this plugin locally.
@Josh-Walker-GM Josh-Walker-GM removed this from the RSC milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtoar @Josh-Walker-GM