Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): add trailing commas #10190

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

Josh-Walker-GM
Copy link
Collaborator

This PR simply runs yarn lint --fix which has added trailing commas. This is now the expected result of prettier as in v3 they changed the default for trailingComma - see here for more detail.

We could have updated our config to keep the current style but it was felt staying with defaults was better.

@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Mar 11, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the chore milestone Mar 11, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Mar 11, 2024
@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) March 11, 2024 07:20
@Josh-Walker-GM Josh-Walker-GM merged commit 36fa1dd into main Mar 11, 2024
40 of 42 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw-lint/trailing-commas branch March 11, 2024 07:44
jtoar added a commit that referenced this pull request Mar 12, 2024
@jtoar jtoar modified the milestones: chore, next-release-major Mar 14, 2024
jtoar added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants