chore(ci): try yarn installing after npx crwa #10176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
added
release:chore
jtoar
changed the title
|
Both the RSC smoke tests and the SSR smoke tests upgrade to canary. Only the RSC one has been failing consistently. It looks like for one particular run at least, the RSC smoke tests gets a slightly later canary than SSR 
|
jtoar
added a commit
that referenced
this pull request
Mar 9, 2024
) #10176 didn't work, but I did discover that the SSR test project seems to always be one canary behind and completes successfully: #10176 (comment). It uses `yarn rw upgrade`. Let's see if that works for RSC too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this will be effective yet, but trying to fix the CI errors we're seeing with canary versions not being found (e.g. https://github.com/redwoodjs/redwood/actions/runs/8213589113/job/22465174520#step:9:49). This just runs yarn install after running create redwood app. Before, the error would surface when we first added a package in
yarn rw exp setup-streaming-ssr. There's no lock file before yarn add is being run. Will be hard to tell if it works since it's only intermittently failing, but just have to try some things.