fix(deploy): handle server file #10061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-flightcontrol/handle-server-file
branch
from
6fbfed3
to
cff7745
Compare
jtoar
force-pushed
the
ds-flightcontrol/handle-server-file
branch
from
cff7745
to
e2eac7f
Compare
jtoar
changed the title
jtoar
commented
Feb 29, 2024
| @@ -38,7 +38,7 @@ services: | |||
| plan: free | |||
| env: node | |||
| region: oregon | |||
| buildCommand: corepack enable && yarn && yarn rw build api | |||
| buildCommand: corepack enable && yarn install && yarn rw build api | |||
There was a problem hiding this comment.
This is just stylistic to be consistent with the web build command above
jtoar
commented
Feb 29, 2024
| const apiProdCommand = ['yarn', 'rw', 'build', 'api', '&&'] | ||
| if (!hasServerFile) { | ||
| if (serverFileExists()) { |
There was a problem hiding this comment.
The logic was flipped here and was a bug
jtoar
commented
Feb 29, 2024
| export const isServerFileSetup = () => { | ||
| if (!serverFileExists) { | ||
| if (!serverFileExists()) { |
There was a problem hiding this comment.
Seems to have been a bug here where we were just checking the truthiness of a function
jtoar
commented
Feb 29, 2024
Comment on lines
+83
to
+84
| const serverFilePath = path.join(rwjsPaths.api.dist, 'server.js') | ||
| const hasServerFile = fs.pathExistsSync(serverFilePath) |
There was a problem hiding this comment.
Still checking dist specifically here because this command is called after build
jtoar
commented
Feb 29, 2024
Comment on lines
-61
to
-62
| extendEnv: true, | ||
| cleanup: true, |
There was a problem hiding this comment.
These default to true
jtoar
added a commit
that referenced
this pull request
Feb 29, 2024
At first this PR was similar to #10055 but for Flightcontrol. But in the process of testing that and updating deploy target CI, I noticed a few other things were off: - coherence logic for the server file was flipped. fixed here - in general, a few duplicate ways of checking for the server file. tried to dedupe them the best i could without making massive changes - stylistic change to render - the flightcontrol setup wasn't handing corepack Test as much as I could locally. Going to get this one into next so I can test in deploy target CI.
jtoar
added a commit
that referenced
this pull request
Feb 29, 2024
At first this PR was similar to #10055 but for Flightcontrol. But in the process of testing that and updating deploy target CI, I noticed a few other things were off: - coherence logic for the server file was flipped. fixed here - in general, a few duplicate ways of checking for the server file. tried to dedupe them the best i could without making massive changes - stylistic change to render - the flightcontrol setup wasn't handing corepack Test as much as I could locally. Going to get this one into next so I can test in deploy target CI.
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 29, 2024
* 'main' of github.com:redwoodjs/redwood: RSC: Fix server build root (redwoodjs#10076) chore(release): update changelog RSC: Add build step debug logs (redwoodjs#10078) fix(deploy): handle server file (redwoodjs#10061) RSC: Fix node-loader message typo (redwoodjs#10077) chore(release): update changelog chore(docs): Add link to SuperTokens auth (redwoodjs#10067) chore(release): update changelog RSC: chore - upgrade @tobbe.dev/rsc-test to v0.0.5 (redwoodjs#10073) chore(.vscode): Enable find inside root __fixtures__ (redwoodjs#10072) chore(deps): bump es5-ext from 0.10.62 to 0.10.64 (redwoodjs#10071) fix(coherence): update setup command to detect server file (redwoodjs#10060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first this PR was similar to #10055 but for Flightcontrol. But in the process of testing that and updating deploy target CI, I noticed a few other things were off:
Test as much as I could locally. Going to get this one into next so I can test in deploy target CI.