Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework types to better support getting *full* dispatch type #372

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EskiMojo14
Copy link
Contributor

@EskiMojo14 EskiMojo14 commented Jun 29, 2024

Breaking changes:

  • Change ThunkAction signature from ThunkAction<ReturnType, State, ExtraThunkArg, BasicAction> to ThunkAction<Dispatch, State, ExtraThunkArg, ReturnType>
  • Remove action overload and union overload from middleware type
    • Dispatch must explicitly be cast to ThunkDispatch for union to be supported
  • Rework type signature for thunk overload to use this to infer Dispatch type
    • this allows other overloads to be accounted for automatically

Copy link

codesandbox-ci bot commented Jun 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant