-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/use dark mode preference to set initial theme.light #861
Feat/use dark mode preference to set initial theme.light #861
Conversation
ad0d2eb
to
c3ec188
Compare
c3ec188
to
9f6ba05
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Sorry for taking so long to look at it.
9f6ba05
to
5a4b3e5
Compare
I've implemented the changes requested in #861 (comment) |
…ght` if user has not set a preferred theme
Error message: 0:0 error Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser. The file does not match your project config: test/__mocks__/styleMock.ts. The file must be included in at least one of the projects provided
5a4b3e5
to
09f7a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your help! 🚀 Sorry for the delayed reviews.
@@ -3,6 +3,6 @@ module.exports = { | |||
setupFilesAfterEnv: ['<rootDir>/test/setup.ts'], | |||
testEnvironment: 'jsdom', | |||
moduleNameMapper: { | |||
'\\.css$': '<rootDir>/test/__mocks__/styleMock.ts', | |||
'\\.css$': '<rootDir>/test/__mocks__/styleMock.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it causing problems for this to be ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not recall exactly, luckily I wrote a detailed commit message.
chore(@redux-devtools/app): fix lint error
Error message:
0:0 error Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: test/__mocks__/styleMock.ts.
The file must be included in at least one of the projects provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice commit message! I wonder if this was fixed by #867.
Description
Displays
@redux-devtools/app
andredux-devtools-extension
in dark mode if the following conditions are all true:settings > theme
form.