Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1382 - React Native - Hermes Engine isn't supporting for await yet #1430

Closed
wants to merge 7 commits into from
Closed

Conversation

LunatiqueCoder
Copy link

@LunatiqueCoder LunatiqueCoder commented Jul 3, 2023

Hello!

This PR fixes #1382. Shortly, React Native's JavaScript Engine, Hermes, isn't supporting for await syntax yet (see facebook/hermes#1089) and with the changes in this PR, @redux-devtools/remote can used by React Native developers.

Additional context: Question #1429 from Discussions section

I had some issues with TypeScript here and there, most of them I actually inherited when forking the project. Would appreciate some help fixing them.

Thank you!

@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2023

⚠️ No Changeset found

Latest commit: 2a47b9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LunatiqueCoder LunatiqueCoder changed the title Fix #1382 - React Native - Hermes Engine doesn't handle for await very well Fix #1382 - React Native - Hermes Engine isn't supporting for await yet Aug 10, 2023
@uloco
Copy link

uloco commented Aug 21, 2023

omg can we please merge this! with all the problems flipper and hermes has, this is the only way to use redux devtools on react native right now. Is there any blocker or anything I can do?

@Methuselah96
Copy link
Member

Sorry for the late response! This should be fixed in @redux-devtools/remote@0.8.1 (release) by #1496, let me know if not.

@keeslinp
Copy link

keeslinp commented Nov 2, 2023

Sorry for the late response! This should be fixed in @redux-devtools/remote@0.8.1 (release) by #1496, let me know if not.

@Methuselah96 I'm on 0.8.1 and I'm seeing this error

Possible Unhandled Promise Rejection (id: 1):
TypeError: Object is not async iterable
TypeError: Object is not async iterable

I'm thinking it is related to this issue, but I'm not sure.
Here's the code that is creating the _asyncIterator

for (var _iterator2 = _asyncIterator(this.socket.listener('error')), _step2; _iteratorAbruptCompletion2 = !(_step2 = await _iterator2.next()).done; _iteratorAbruptCompletion2 = false) {

@LunatiqueCoder
Copy link
Author

@Methuselah96 Yep, this is not fixed. I will continue using the patch.

image

@evgenyshenets91
Copy link

same.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React-native Hermes app has an issue with for await
5 participants