-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add size-limit
config
#2173
base: master
Are you sure you want to change the base?
Add size-limit
config
#2173
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Honestly, I'm not a huge fan of these sorts of tools. They tend to be more annoying than helpful. Maybe we can limit it to just a Edit: Wait, don't we already have this? https://github.com/reduxjs/react-redux/blob/master/.github/workflows/size.yaml |
That's fair, but
While The idea is to have this here so that if we were ever to make a set of changes, we could use it to keep an eye on bundle sizes, it doesn't necessarily have to put a "limit" on anything. |
yeah, while I don't think the concept of a size "limit" is very useful, I do find it useful to have visibility on how a given set of changes affects final bundle size. |
Could this supplant our usage of compressed-size-action? That one hasn't been updated in a long time and causes some warnings in CI that will eventually turn into errors, so it's been on my radar to replace it. |
I guess we could use https://github.com/EskiMojo14/size-limit-action, same thing we're doing with RTK. |
✅ Deploy Preview for react-redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
97056ad
to
bef6ea4
Compare
Yeah, I think we want to switch to the other size package for consistency. |
The other size package? |
6f0d771
to
ea2465e
Compare
- Cut down on `size-limit` config to not go through every single entry point.
ea2465e
to
a3a46e7
Compare
This PR:
size-limit
config to monitor bundle size changes in preparation for any potential changes we'll have to make to migrate to React 19.