Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy tests on commit #56

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Run mypy tests on commit #56

merged 3 commits into from
Aug 29, 2023

Conversation

Spartee
Copy link
Contributor

@Spartee Spartee commented Aug 29, 2023

Run the following on commit

  • mypy
  • black
  • isort

Also lots of fixes to satisfy mypy

@Spartee Spartee added enhancement New feature or request CI/CD labels Aug 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #56 (f12f0a8) into main (e5c7579) will decrease coverage by 0.35%.
The diff coverage is 83.11%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   87.56%   87.22%   -0.35%     
==========================================
  Files          15       15              
  Lines         780      814      +34     
==========================================
+ Hits          683      710      +27     
- Misses         97      104       +7     
Files Changed Coverage Δ
redisvl/vectorize/text/huggingface.py 82.35% <ø> (ø)
redisvl/vectorize/text/openai.py 76.56% <ø> (ø)
redisvl/index.py 87.17% <66.66%> (ø)
redisvl/query/filter.py 90.79% <78.84%> (-4.66%) ⬇️
redisvl/llmcache/semantic.py 89.74% <100.00%> (ø)
redisvl/query/__init__.py 100.00% <100.00%> (ø)
redisvl/query/query.py 93.81% <100.00%> (+2.32%) ⬆️
redisvl/utils/utils.py 86.53% <100.00%> (ø)
redisvl/vectorize/base.py 79.31% <100.00%> (ø)

@Spartee Spartee merged commit 125df51 into main Aug 29, 2023
6 checks passed
@tylerhutcherson tylerhutcherson deleted the mypy-check branch October 16, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants