Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support distance threshold override #202

Merged

Conversation

tylerhutcherson
Copy link
Collaborator

At runtime, we should extend the ability to override the distance threshold if provided. This is also how the semantic router works. Parity between the extensions is key here (in terms of functionality)

Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing and I think there's now a validation error from the pydantic class in the test

redisvl/extensions/llmcache/semantic.py Outdated Show resolved Hide resolved
@tylerhutcherson tylerhutcherson force-pushed the feat/RAAE-221/support-distance-threshold-override branch from cf5a512 to f927dd3 Compare August 16, 2024 15:38
@tylerhutcherson tylerhutcherson merged commit 13dcd66 into main Aug 16, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-221/support-distance-threshold-override branch August 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants