Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic cache with empty metadata #201

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

We found a bug where metadata={} was not getting handled correctly.

@tylerhutcherson tylerhutcherson added the bug Something isn't working label Aug 12, 2024
Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the one comment we can trim

redisvl/extensions/llmcache/semantic.py Outdated Show resolved Hide resolved
rbs333
rbs333 previously approved these changes Aug 13, 2024
@tylerhutcherson tylerhutcherson merged commit 99bc5a1 into main Aug 16, 2024
16 of 20 checks passed
@tylerhutcherson tylerhutcherson deleted the fix/RAAE-220/cache-empty-metadata branch August 16, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants