Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ChatMessage pydantic model #194

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Use ChatMessage pydantic model #194

merged 5 commits into from
Jul 31, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

Uses pydantic for validation, docs, and custom serialization of chat message objects on the way into and out of Redis.

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Jul 31, 2024
justin-cechmanek
justin-cechmanek approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few simple doc strings to the utils, but otherwise it looks good!

@justin-cechmanek justin-cechmanek merged commit 8bbd1b0 into main Jul 31, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-195/chat-message-model branch August 1, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-cechmanek justin-cechmanek justin-cechmanek approved these changes

@rbs333 rbs333 Awaiting requested review from rbs333

Assignees

@justin-cechmanek justin-cechmanek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerhutcherson @justin-cechmanek