Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize extensions redis init #188

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

Standardizes the way our extension modules connect to redis.

  • First check for client
  • Then check for URL
  • Then raise a CLEAR error if neither are provided

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Jul 26, 2024
@tylerhutcherson
Copy link
Collaborator Author

(I need to fix the failing test on the notebook)

@justin-cechmanek
Copy link
Collaborator

Looks good. Just curious why we don't want to have a default redis url anymore

@tylerhutcherson
Copy link
Collaborator Author

Looks good. Just curious why we don't want to have a default redis url anymore

Certainly open to discussing this with everyone more. Let me ping the rest of the team to see what the collective thoughts are. My preference is for these to be less magicy and focus on clarity. But if it'a a common of enough pattern, we can go for it.

@tylerhutcherson
Copy link
Collaborator Author

Looks good. Just curious why we don't want to have a default redis url anymore

Certainly open to discussing this with everyone more. Let me ping the rest of the team to see what the collective thoughts are. My preference is for these to be less magicy and focus on clarity. But if it'a a common of enough pattern, we can go for it.

After reviewing with team, we went back to defaulting to localhost Redis.

@tylerhutcherson tylerhutcherson added the bug Something isn't working label Jul 29, 2024
Copy link
Collaborator

@justin-cechmanek justin-cechmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tylerhutcherson tylerhutcherson merged commit cb61457 into main Jul 30, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the fix/RAAE-198/client-instantiation branch July 30, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants