Add ability drop all keys from the index #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs333
previously approved these changes
Jul 11, 2024
tylerhutcherson
previously approved these changes
Jul 11, 2024
redisvl/index/index.py
Outdated
| @@ -935,6 +945,16 @@ async def clear(self) -> int: | |||
|
|
|||
| return total_records_deleted | |||
|
|
|||
| async def drop_keys(self, keys: Union[str, List[str]]) -> None: | |||
There was a problem hiding this comment.
Sorry one quick thing. delete returns the count of keys dropped. With the clear method, I though it might be valuable to return the count here. Should be easy to do the same
tylerhutcherson
approved these changes
Jul 17, 2024
tylerhutcherson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From our chat today I'm pulling out this method from the semantic cache and moving it into index. Rather can modify the
clear()method to take an optional list of keys it's a new method.The goal is to stop the accidental calling of clear() with no args, thinking it will clear no keys, but actually delete everything.