Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoyageAI vectorizer and reranker #152

Closed
wants to merge 14 commits into from
Closed

VoyageAI vectorizer and reranker #152

wants to merge 14 commits into from

Conversation

fzowl
Copy link

@fzowl fzowl commented May 13, 2024

No description provided.

@bsbodden bsbodden self-requested a review May 15, 2024 17:19
@bsbodden bsbodden added the enhancement New feature or request label May 15, 2024
Copy link
Collaborator

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fzowl fzowl requested a review from bsbodden June 7, 2024 14:52
@bsbodden
Copy link
Collaborator

bsbodden commented Jun 8, 2024

@fzowl there are tests failing in our test matrix, can you address them before the branch goes stale?

@fzowl
Copy link
Author

fzowl commented Jun 8, 2024

@bsbodden The failed tests seem to be related to GCP credentials, not during the code tests but during the Authenticate to GCP step, which is in your control, I believe. Can you please help me out with what the issue could be here?
Screenshot 2024-06-08 at 12 14 54

@tylerhutcherson
Copy link
Collaborator

Will take a look and see if we can get this wrapped up, thanks team!

Reformatting
Adding VoyageAI to enum
@fzowl
Copy link
Author

fzowl commented Sep 16, 2024

@tylerhutcherson Thank you!

@fzowl
Copy link
Author

fzowl commented Sep 19, 2024

@tylerhutcherson Any progress on this? Is there anything i can help?

Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's great -- just a few things I caught when reviewing. I will get an API key today to set up in our CI. Also looks like there is an issue with the lockfile:

https://github.com/redis/redis-vl-python/actions/runs/10885688987/job/30434690376?pr=152

@tylerhutcherson
Copy link
Collaborator

FYI @fzowl im working on fixing tests over here: #223
will merge when I have it all working. Needed to address the lockfile, formatting/linting, and one other thing.

@fzowl
Copy link
Author

fzowl commented Sep 21, 2024

@tylerhutcherson Thank you very much! I was struggling a bit with the lockfile, i tried to update it but it was hanging every time for me. Thank you very much for your help!

@tylerhutcherson
Copy link
Collaborator

@tylerhutcherson Thank you very much! I was struggling a bit with the lockfile, i tried to update it but it was hanging every time for me. Thank you very much for your help!

No problem! We're happy to support more integrations, and sorry this took so long. We just had a slew of customer requests we needed to focus on first. @fzowl I will close this PR in favor of the other, and plan to release soon. Will VoyageAI do any kind of announcement about the new integration or maybe host an example in your docs? That would be rad.

@fzowl
Copy link
Author

fzowl commented Sep 21, 2024

@tylerhutcherson Yes, i will add RedisVL to our integrations in our site.
I have one more question, is the API documentation automatically generated or shall i extend with VoyageAI? (https://www.redisvl.com/api/vectorizer.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants